[dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx offloads flags field

Lu, Wenzhuo wenzhuo.lu at intel.com
Tue Jan 9 07:30:01 CET 2018


Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing <jingjing.wu at intel.com>; Yigit, Ferruh
> <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx
> offloads flags field
> 
> The tx_ol_flags field was used in order to control the different Tx offloads
> set. After the conversion to the new Ethdev Tx offloads API it is not needed
> anymore as the offloads configuration is stored in ethdev structs.
> 
> Signed-off-by: Shahaf Shuler <shahafs at mellanox.com>
> ---
>  app/test-pmd/cmdline.c  | 49 ++++++++++++++++----------------------------
>  app/test-pmd/config.c   |  4 ----
>  app/test-pmd/csumonly.c | 40 ++++++++++++++++++------------------
>  app/test-pmd/flowgen.c  |  8 +++++---
>  app/test-pmd/macfwd.c   |  8 +++++---
>  app/test-pmd/macswap.c  |  8 +++++---
>  app/test-pmd/testpmd.h  | 22 +-------------------
>  app/test-pmd/txonly.c   |  8 +++++---
>  8 files changed, 59 insertions(+), 88 deletions(-)
> 


> +195,7 @@ struct rte_port {
>  	struct fwd_stream       *rx_stream; /**< Port RX stream, if unique */
>  	struct fwd_stream       *tx_stream; /**< Port TX stream, if unique */
>  	unsigned int            socket_id;  /**< For NUMA support */
> -	uint16_t                tx_ol_flags;/**< TX Offload Flags
> (TESTPMD_TX_OFFLOAD...). */
> +	uint16_t		parse_tunnel:1; /**< Parse internal headers
This flag looks a little incongruous here, but anyway we have to have it.

Acked-by: Wenzhuo Lu <wenzhuo.lu at intel.com>


More information about the dev mailing list