[dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function

Aaron Conole aconole at redhat.com
Tue Jan 9 17:44:39 CET 2018


Hi Erik,

Erik Gabriel Carrillo <erik.g.carrillo at intel.com> writes:

> Update rte_lcore_has_role() so that it returns true/false instead of
> success/failure.
>
> Fixes: 78666372fa2b ("eal: add function to check lcore role")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>
> ---

I believe this breaks the published abi - Success is now 'true', and
failure is 'false';  previously success would be 0 == false.  You'll
need to invert the test, or note that the abi is breaking (since
semantically any caller will need to invert the test).


More information about the dev mailing list