[dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

Lu, Wenzhuo wenzhuo.lu at intel.com
Thu Jan 11 03:07:41 CET 2018


Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, January 11, 2018 1:15 AM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Cc: dev at dpdk.org; Wu, Jingjing <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD
> 
> On Wed, 10 Jan 2018 14:15:49 +0800
> Wenzhuo Lu <wenzhuo.lu at intel.com> wrote:
> 
> > +
> > +#define AVF_MAX_NUM_QUEUES       16
> > +/* Vlan table size */
> > +#define AVF_VLAN_TB_SIZE               (4096 / (CHAR_BIT * sizeof(uint32_t)))
> 
> You could use ETHER_MAX_VLAN_ID (which is 4095).
> Also it is most efficient if bit tables use unsigned long to access.
Thanks for the suggestion.
I found this macro is useless. I'd like just removing it.

Hi Ferruh,
As this patch set is accepted to next-net, I can sent a fixes patch for this change. Is it OK? Would you like helping merge the fixes to the original patch? Thanks.



More information about the dev mailing list