[dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit

Zhang, Helin helin.zhang at intel.com
Sat Jan 13 07:33:58 CET 2018



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Thursday, January 11, 2018 4:23 PM
> To: chas3 at att.com; dev at dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and
> transmit
> 
> Hi,
> 
> > Date: Thu, 19 Oct 2017 23:23:39 -0400
> >
> > From: Chas Williams <chas3 at att.com>
> >
> > The transmit and receive controller state machines are only enabled
> > after receiving an interrupt and the link status is now valid.  If an
> > adapter is being used in conjunction with NC-SI, network controller
> > sideband interface, the adapter may never get a link state change
> > interrupt since the adapter's PHY is always link up and never changes state.
> >
> > To fix this, always enable and disable the transmit and receive with
> > .dev_start and .dev_stop.  This is a better match for what is
> > typically done with the other PMD's.  Since we may never get an
> > interrupt to check the link state, we also poll once at the end of
> > .dev_start to get the current link status.
> >
> > Signed-off-by: Chas Williams <chas3 at att.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin


More information about the dev mailing list