[dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

Andriy Berestovskyy aber at semihalf.com
Mon Jan 22 19:20:32 CET 2018


Hey Harry,
Thanks for the review.

On Fri, Jan 19, 2018 at 6:31 PM, Van Haaren, Harry
<harry.van.haaren at intel.com> wrote:
> These changes do reduce false-sharing however is there actually a performance benefit? A lot of cache space will be taken up if each core requires its own cache line, which will reduce performance again.. it's a tradeoff.

1. False sharing is happening in the data path vs loops in control paths.

2. The original code (prior e70a61ad50ab "keepalive: export states")
had each element aligned to the cache line, not the whole array.


> Little fix for a v2: "s" is not a good variable name for the rte_keepalive_state, please use something more descriptive.

Sure, if there are no more comments, I'll change it.


Andriy


More information about the dev mailing list