[dpdk-dev] [dpdk-stable] [PATCH v3] cmdline: fix dynamic tokens parsing

Thomas Monjalon thomas at monjalon.net
Thu Jan 25 23:14:54 CET 2018


22/01/2018 14:13, Olivier Matz:
> On Sat, Jan 20, 2018 at 02:16:10AM +0800, Xueming Li wrote:
> > When using dynamic tokens, the result buffer contains pointers to some
> > location inside the result buffer. When the content of the temporary
> > buffer is copied in the final one, these pointers still point to the
> > temporary buffer.
> > 
> > This works until the temporary buffer is kept intact, but the next
> > commit introduces a memset() that breaks this assumption.
> > 
> > This commit keeps the successfully parsed buffers, and ensures that the
> > pointers point to the valid location, by using temp buffer for following
> > parsing.
> > 
> > Fixes: 9b3fbb051d2e ("cmdline: fix parsing")
> > Cc: stable at dpdk.org
> > Signed-off-by: Xueming Li <xuemingl at mellanox.com>
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>

Applied, thanks


More information about the dev mailing list