[dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init

Van Haaren, Harry harry.van.haaren at intel.com
Fri Jan 26 11:10:23 CET 2018


> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, January 25, 2018 10:11 PM
> To: Varghese, Vipin <vipin.varghese at intel.com>
> Cc: dev at dpdk.org; Van Haaren, Harry <harry.van.haaren at intel.com>;
> Richardson, Bruce <bruce.richardson at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] service: fix memory leak by
> rte_service_init
> 
> 11/01/2018 19:20, Vipin Varghese:
> > This patch fixes the memory leak created by rte_service_init. When
> > secondary application which shares the huge page from primary, is
> > executed multiple times memory is initialized but not freed on exit
> >
> > The rte_service_finalize checks if the service is initialized. If yes,
> > it frees up rte_services & lcore_states. The API has to be called at
> > end of application run.
> >
> > renamed the function from rte_service_deinit to rte_service_finalize.
> 
> This is a changelog. It should appear below ---
> 
> > Signed-off-by: Vipin Varghese <vipin.varghese at intel.com>
> 
> Why not keeping previous ack?
> 
> Your patches have been set to "Not Applicable" in patchwork.
> What happened?


There was some confusion in my review-comments, and Vipin and I discussed
the best was to rework - I suggested marking the current patches as Not Applicable.

Is there a better state to put the patches in Patchwork if we don't want commiters to look at them?
Or would an email to the thread stating V+1 in progress be better?

A new version will hit the ML soon.


More information about the dev mailing list