[dpdk-dev] [PATCH 1/2] test/memzone: add test for memzone count in eal mem config

Burakov, Anatoly anatoly.burakov at intel.com
Mon Jan 29 10:40:01 CET 2018


On 27-Jan-18 2:53 PM, Radoslaw Biernacki wrote:
> Looks OK.
> 
> Following note is aside from the patch.
> Might be beneficial (in some rare cases) to add bailout recovery with
> goto's in test_memzone_basic()
> Just in case one of the rte_memzone_reserve() we should not make return -1,
> but instead a goto to below section where we call rte_memzone_free().
> This way we would be able to free only the allocated memzones and prevent
> leaking out those memzones to other tests.

Thanks, and yep, it's on my todo list :) didn't get around to it yet.

> 
> Reviewed-by: Radoslaw Biernacki <r <ferruh.yigit at intel.com>
> adoslaw.biernacki at linaro.com>
> 


-- 
Thanks,
Anatoly


More information about the dev mailing list