[dpdk-dev] [PATCH v4 3/4] app/pdump: call eal cleanup before exit

Harry van Haaren harry.van.haaren at intel.com
Mon Jan 29 17:00:41 CET 2018


This patch adds a call to the newly introduced cleanup()
function just before quitting the pdump app.

Adding this function call before quitting from a secondary processes
is important, as otherwise it will leak hugepage memory. For a secondary
process that is run multiple times, this could cause hugepage memory
to become depleted and stop a secondary process from starting.

Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
Acked-by: Vipin Varghese <vipin.varghese at intel.com>

---

v4:
- Include Ack

v3:
- Rework to new cleanup() function name (Thomas)

Cc: thomas at monjalon.net
Cc: vipin.varghese at intel.com
---
 app/pdump/main.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 0f70c75..50772cb 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -882,5 +882,10 @@ main(int argc, char **argv)
 	/* dump debug stats */
 	print_pdump_stats();
 
+	ret = rte_eal_cleanup();
+	if (ret)
+		printf("Error from rte_eal_cleanup(), %d\n", ret);
+
+
 	return 0;
 }
-- 
2.7.4



More information about the dev mailing list