[dpdk-dev] [PATCH v1] mk: support building with renamed makefile

Varghese, Vipin vipin.varghese at intel.com
Mon Jan 29 17:14:48 CET 2018



> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Monday, January 22, 2018 4:29 PM
> To: dev at dpdk.org
> Cc: thomas at monjalon.net; Varghese, Vipin <vipin.varghese at intel.com>;
> Kovacevic, Marko <marko.kovacevic at intel.com>; stable at dpdk.org
> Subject: [PATCH v1] mk: support building with renamed makefile
> 
> The build system made a recursive call to "make" after creating the build
> directory. This recursive call used the hard-coded filename "Makefile", which
> prevented builds from working if the file was renamed and make called using
> "make -f". Taking the filename from MAKEFILES_LIST make variable fixes this.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic at intel.com>
> ---
>  mk/internal/rte.extvars.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk index
> 94f27e9..19594da 100644
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
> @@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line")  RTE_EXTMK :=
> $(abspath $(M))  endif  endif -RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
> +RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
>  export RTE_EXTMK
> 
>  # RTE_SDK_BIN must point to .config, include/ and lib/.
> --
> 2.9.5

I have validated on Linux environment with custom make file name as 'Makefile.test'.

Acked-by: Vipin Varghese <vipin.varghese at intel.com>



More information about the dev mailing list