[dpdk-dev] [PATCH v3 1/7] vhost: use shadow used ring in dequeue path

[Maxime Coquelin]

On 07/03/2018 05:28 AM, Tiwei Bie wrote:
> On Wed, Jun 27, 2018 at 04:49:53PM +0200, Maxime Coquelin wrote:
> [...]
>> @@ -1164,8 +1136,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
>>   
>>   			if (mbuf_is_consumed(zmbuf->mbuf)) {
>>   				used_idx = vq->last_used_idx++ & (vq->size - 1);
> 
> Above line and other `used_idx` related code in
> this function should be removed too.

Yes, of course.

> 
> Apart from that,
> Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>


Thanks!
Maxime

> Thanks!
> 
>> -				update_used_ring(dev, vq, used_idx,
>> -						 zmbuf->desc_idx);
>> +				update_shadow_used_ring(vq, zmbuf->desc_idx, 0);
>>   				nr_updated += 1;
>>   
>>   				TAILQ_REMOVE(&vq->zmbuf_list, zmbuf, next);
> [...]
>