[dpdk-dev] [PATCH v3 3/8] hash: fix to have more accurate key slot size

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Mon Jul 9 16:20:09 CEST 2018



> -----Original Message-----
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> Cc: dev at dpdk.org; Wang, Yipeng1 <yipeng1.wang at intel.com>; Richardson,
> Bruce <bruce.richardson at intel.com>; honnappa.nagarahalli at arm.com;
> vguvva at caviumnetworks.com; brijesh.s.singh at gmail.com
> Subject: [PATCH v3 3/8] hash: fix to have more accurate key slot size

Titles always start with a verb whereas in your case, you are starting with a noun.
Better to change it to "fix key slot size accuracy"?

Apart from that:

Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>

> 
> This commit calculates the needed key slot size more accurately. The previous
> local cache fix requires the free slot ring to be larger than actually needed.
> The calculation of the value is inaccurate.
> 
> Fixes: 5915699153d7 ("hash: fix scaling by reducing contention")
> Cc: stable at dpdk.org



More information about the dev mailing list