[dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT) driver

[De Lara Guarch, Pablo]

Hi Anoob,

> -----Original Message-----
> From: Anoob Joseph [mailto:anoob.joseph at caviumnetworks.com]
> Sent: Tuesday, July 10, 2018 4:41 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; 'Akhil Goyal'
> <akhil.goyal at nxp.com>
> Cc: 'Thomas Monjalon' <thomas at monjalon.net>; 'Ankur Dwivedi'
> <ankur.dwivedi at cavium.com>; 'Jerin Jacob'
> <jerin.jacob at caviumnetworks.com>; 'Murthy NSSR'
> <Nidadavolu.Murthy at cavium.com>; 'Narayana Prasad'
> <narayanaprasad.athreya at caviumnetworks.com>; 'Nithin Dabilpuram'
> <nithin.dabilpuram at cavium.com>; 'Ragothaman Jayaraman'
> <Ragothaman.Jayaraman at cavium.com>; 'Srisivasubramanian Srinivasan'
> <Srisivasubramanian.Srinivasan at cavium.com>; 'dev at dpdk.org'
> <dev at dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT)
> driver
> 
> Hi Pablo,
> 
> Thanks for the review. We had made some architectural modifications to the
> PMD while addressing your comments. This is taking longer than expected and
> so we might as well defer the v2 to the next release cycle.
> Is that fine?
> 
> Do you suggest submitting the patches as and when it is ready or should I wait
> till next release cycle?

It's ok to defer to next release, no problem. I suggest to wait until 18.08 is out, to make sure that people don't forget about it when they are focused on 18.08 last changes.


> 
> > Please, take into account the following patchset which will be applied
> > tomorrow (just waiting for a couple of acks):
> 
> > http://patches.dpdk.org/user/todo/dpdk/?series=416
> 
> This series is integrated.
> 
> Thanks,
> Anoob
> 
> On 10-07-2018 04:25, De Lara Guarch, Pablo wrote:
> > External Email
> >
> >> -----Original Message-----
> >> From: De Lara Guarch, Pablo
> >> Sent: Monday, June 18, 2018 3:30 PM
> >> To: Anoob Joseph <Anoob.Joseph at caviumnetworks.com>; Akhil Goyal
> >> <akhil.goyal at nxp.com>
> >> Cc: Thomas Monjalon <thomas at monjalon.net>; Ankur Dwivedi
> >> <ankur.dwivedi at cavium.com>; Jerin Jacob
> >> <jerin.jacob at caviumnetworks.com>; Murthy NSSR
> >> <Nidadavolu.Murthy at cavium.com>; Narayana Prasad
> >> <narayanaprasad.athreya at caviumnetworks.com>; Nithin Dabilpuram
> >> <nithin.dabilpuram at cavium.com>; Ragothaman Jayaraman
> >> <Ragothaman.Jayaraman at cavium.com>; Srisivasubramanian Srinivasan
> >> <Srisivasubramanian.Srinivasan at cavium.com>; dev at dpdk.org
> >> Subject: RE: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto
> >> device(CPT) driver
> >>
> >> Hi Anoob,
> >>
> >>> -----Original Message-----
> >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Anoob Joseph
> >>> Sent: Monday, June 18, 2018 2:02 PM
> >>> To: Akhil Goyal <akhil.goyal at nxp.com>; De Lara Guarch, Pablo
> >>> <pablo.de.lara.guarch at intel.com>
> >>> Cc: Thomas Monjalon <thomas at monjalon.net>; Ankur Dwivedi
> >>> <ankur.dwivedi at cavium.com>; Jerin Jacob
> >>> <jerin.jacob at caviumnetworks.com>; Murthy NSSR
> >>> <Nidadavolu.Murthy at cavium.com>; Narayana Prasad
> >>> <narayanaprasad.athreya at caviumnetworks.com>; Nithin Dabilpuram
> >>> <nithin.dabilpuram at cavium.com>; Ragothaman Jayaraman
> >>> <Ragothaman.Jayaraman at cavium.com>; Srisivasubramanian Srinivasan
> >>> <Srisivasubramanian.Srinivasan at cavium.com>; dev at dpdk.org
> >>> Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto
> >>> device(CPT) driver
> >>>
> >>> Hi Akhil, Pablo,
> >>>
> >>> Are there any top level comments on this?
> >> Sorry for the delay. I didn't have the time to review this yet.
> >> Will do that asap.
> > Hi Anoob,
> >
> > I had some comments on this patchset.
> > Could you address these comments and send a v2?
> > Please, take into account the following patchset which will be applied
> > tomorrow (just waiting for a couple of acks):
> >
> > http://patches.dpdk.org/user/todo/dpdk/?series=416
> >
> >
> >> Thanks,
> >> Pablo