[dpdk-dev] [PATCH] ethdev: fix flow expansion matching types

Nelio Laranjeiro nelio.laranjeiro at 6wind.com
Wed Jul 11 08:49:35 CEST 2018


Node RSS types are generally covering more RSS kind than the user is
requesting, it should accept to expand even if only a single bit is
remains after masking.  Setting the correct RSS kind for the rule
remains the driver job.

Fixes: 959823ce4c47 ("ethdev: add flow API to expand RSS flows")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
---
 lib/librte_ethdev/rte_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index 2b13efca7..e06cc2193 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -585,7 +585,7 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
 	node = next_node ? &graph[*next_node] : NULL;
 	while (node) {
 		flow_items[stack_pos].type = node->type;
-		if ((node->rss_types & types) == node->rss_types) {
+		if (node->rss_types & types) {
 			/*
 			 * compute the number of items to copy from the
 			 * expansion and copy it.
-- 
2.18.0



More information about the dev mailing list