[dpdk-dev] [PATCH v5 02/16] compress/qat: add makefiles for PMD

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Thu Jul 12 14:41:49 CEST 2018



> -----Original Message-----
> From: Trahe, Fiona
> Sent: Wednesday, July 11, 2018 12:57 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Trahe, Fiona
> <fiona.trahe at intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak at intel.com>
> Subject: [PATCH v5 02/16] compress/qat: add makefiles for PMD
> 
> Add Makefiles, directory and empty source files for compression PMD.
> Handle cases for building either symmetric crypto PMD or compression PMD or
> both and the common files both depend on.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe at intel.com>
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
> ---
>  MAINTAINERS                         |  4 +++
>  config/common_base                  |  3 +-
>  drivers/common/qat/Makefile         | 60 +++++++++++++++++++++++--------------
>  drivers/compress/qat/qat_comp.c     |  5 ++++
>  drivers/compress/qat/qat_comp.h     | 14 +++++++++
>  drivers/compress/qat/qat_comp_pmd.c |  5 ++++
> drivers/compress/qat/qat_comp_pmd.h | 15 ++++++++++
>  test/test/test_cryptodev.c          |  6 ++--
>  8 files changed, 86 insertions(+), 26 deletions(-)  create mode 100644
> drivers/compress/qat/qat_comp.c  create mode 100644
> drivers/compress/qat/qat_comp.h  create mode 100644
> drivers/compress/qat/qat_comp_pmd.c
>  create mode 100644 drivers/compress/qat/qat_comp_pmd.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8050b5d..50b2dff 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -852,6 +852,10 @@ F: drivers/compress/isal/
>  F: doc/guides/compressdevs/isal.rst
>  F: doc/guides/compressdevs/features/isal.ini
> 
> +Intel QuickAssist
> +M: Fiona Trahe <fiona.trahe at intel.com>
> +F: drivers/compress/qat/
> +F: drivers/common/qat/
> 
>  Eventdev Drivers
>  ----------------
> diff --git a/config/common_base b/config/common_base index
> e4241db..1e340b4 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -480,7 +480,8 @@ CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4
>  #
>  # Compile PMD for QuickAssist based devices  # -
> CONFIG_RTE_LIBRTE_PMD_QAT=n
> +CONFIG_RTE_LIBRTE_PMD_QAT=y
> +CONFIG_RTE_LIBRTE_PMD_QAT_SYM=n

Since now you are enabling QAT driver by default, mk/rte.app.mk needs to be changed.
QAT_SYM requires libcrypto, not QAT itself, so right now, by default libcrypto is needed.
A change like the following would solve the problem, but not sure if it is correct.

+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT)         += -lrte_pmd_qat
 ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB)    += -lrte_pmd_aesni_mb
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB)    += -lIPSec_MB
@@ -190,7 +191,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM)   += -lIPSec_MB
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CCP)         += -lrte_pmd_ccp -lcrypto
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OPENSSL)     += -lrte_pmd_openssl -lcrypto
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += -lrte_pmd_null_crypto
-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT)         += -lrte_pmd_qat -lcrypto
+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT_SYM)     += -lcrypto


More information about the dev mailing list