[dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

[Thomas Monjalon]

13/07/2018 19:25, Harry van Haaren:
> v3:
> - Use WARNING instead of ERR log level (Vipin)
> - Put strings on one line for grep-ability (Harry)

We can consider it is OK to have sentences on different lines.
Who is grepping 2 sentences at once?

> v2, thanks for review:
> - Consistency in message endings - vs . (Thomas)

Some dots are missing.

> - Wrap lines as they're very long otherwise (Thomas)

Lines are not wrapped.

> +		RTE_LOG(WARNING, EAL,
> +			"Service cores parsed before dataplane cores Please ensure -c is before -s or -S.\n");

I think this would be better:

		RTE_LOG(WARNING, EAL,
			"Service cores parsed before dataplane cores. "
			"Please ensure -c is before -s or -S.\n");