[dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

Thomas Monjalon thomas at monjalon.net
Mon Jul 16 01:12:38 CEST 2018


27/06/2018 20:01, Neil Horman:
> Recently, some additional patches were added to allow for programmatic
> marking of C symbols as experimental.  The addition of these markers is
> dependent on the manual addition of exported symbols to the EXPERIMENTAL
> section of the corresponding libraries version map file.  The consensus
> on review is that, in addition to mandating the addition of symbols to
> the EXPERIMENTAL version in the map, we need a mechanism to enforce our
> documented process of mandating that addition when they are introduced.
> To that end, I am proposing this change.  It is an addition to the
> checkpatches script, which scan incoming patches for additions and
> removals of symbols to the map file, and warns the user appropriately
> 
> Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
> CC: thomas at monjalon.net
> CC: john.mcnamara at intel.com
> CC: bruce.richardson at intel.com
> CC: Ferruh Yigit <ferruh.yigit at intel.com>
> CC: Stephen Hemminger <stephen at networkplumber.org>
> 
> ---
> +		tmpinput=$(mktemp checkpatches.XXXXXX)
> +		git format-patch --find-renames \
> +		--no-stat --stdout -1 $commit > ./$tmpinput

In case $tmpinput is an absolute path (like in /tmp),
we must not prepend it with ./
I fix it when applying.

Applied, thanks





More information about the dev mailing list