[dpdk-dev] [PATCH v2 08/10] autotest: add new test cases to autotest

[Pattan, Reshma]

Hi,

> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Friday, July 13, 2018 5:41 PM
> To: Pattan, Reshma <reshma.pattan at intel.com>; thomas at monjalon.net;
> dev at dpdk.org
> Cc: Parthasarathy, JananeeX M <jananeex.m.parthasarathy at intel.com>;
> stable at dpdk.org
> Subject: Re: [PATCH v2 08/10] autotest: add new test cases to autotest
> 
> On 13-Jul-18 5:20 PM, Reshma Pattan wrote:
> > Autotest is enhanced with additional test cases being added to
> > autotest_data.py
> 
> You're also removing PCI autotest - commit message needs to call this out as
> well.
> 

OK

> <snip>
> 
> > +    {
> > +        "Name":    "Dump_ring",
> > +        "Command": "dump_ring",
> > +        "Func":    default_autotest,
> > +        "Report":  None,
> > +    },
> > +    {
> > +        "Name":    "Quit",
> > +        "Command": "quit",
> > +        "Func":    default_autotest,
> > +        "Report":  None,
> > +    },
> 
> Why is "quit" an autotest? If you want to test "quit" functionality, i would
> suggest putting it at the end of non-parallel tests, to avoid situation where
> test prematurely stops (for example, this will happen on FreeBSD, where
> there's only one thread executing these tests).
> 
> But really, having it in this list is IMO dubious.
> 
Ok, I will remove this 

> Here and in other "dump" autotests - do these dump tests work as autotests?
> Default autotest function expects a "Test OK" at the end of test, and i don't
> think dump autotests return that, so this will
> (should?) cause a very long timeout and a test failure. These should have
> "dump_autotest" as "Func" value - that function correctly parses output of
> dump autotests (or, to be more accurate, it doesn't - as long as test doesn't
> crash, it's considered to be successful :) ).
> 
> Also, for readability, we should move these dump tests together and have all
> dump tests one after the other.
> 

Ok will add "Func" value  as dump_autotest and move all of the dump tests to end of  parallel list.