[dpdk-dev] [PATCH v2 3/6] compress/octeontx: add xform and stream create support

[Verma, Shally]

>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
>Sent: 14 July 2018 03:55
>To: Verma, Shally <Shally.Verma at cavium.com>
>Cc: dev at dpdk.org; Athreya, Narayana Prasad <NarayanaPrasad.Athreya at cavium.com>; Challa, Mahipal
><Mahipal.Challa at cavium.com>; Gupta, Ashish <Ashish.Gupta at cavium.com>; Gupta, Ashish <Ashish.Gupta at cavium.com>; Sahu,
>Sunila <Sunila.Sahu at cavium.com>
>Subject: RE: [PATCH v2 3/6] compress/octeontx: add xform and stream create support
>
>External Email
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.verma at caviumnetworks.com]
>> Sent: Monday, July 2, 2018 5:55 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
>> Cc: dev at dpdk.org; pathreya at caviumnetworks.com;
>> mchalla at caviumnetworks.com; Ashish Gupta
>> <Ashish.Gupta at caviumnetworks.com>; Ashish Gupta
>> <ashish.gupta at caviumnetworks.com>; Sunila Sahu
>> <sunila.sahu at caviumnetworks.com>
>> Subject: [PATCH v2 3/6] compress/octeontx: add xform and stream create
>> support
>>
>> From: Ashish Gupta <Ashish.Gupta at caviumnetworks.com>
>>
>> implement private xform and stream create ops
>>
>> Signed-off-by: Ashish Gupta <ashish.gupta at caviumnetworks.com>
>> Signed-off-by: Shally Verma <shally.verma at caviumnetworks.com>
>> Signed-off-by: Sunila Sahu <sunila.sahu at caviumnetworks.com>
>> ---
>
>...
>
>>
>> +static int
>> +zip_pmd_stream_create(struct rte_compressdev *dev,
>> +             const struct rte_comp_xform *xform, void **stream) {
>
>Do you support stateful ops? If you don't, this should not be implemented, I think (or should return -ENOTSUP).
For us non-shareable priv_xform are equivalent to stream, so priv_xform_create falls back to stream_create . However, I see your point  so to reflect stateful not supported, we will set stream_create function pointer = NULL in pmd_ops.

Thanks
Shally