[dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

Gaëtan Rivet gaetan.rivet at 6wind.com
Wed Jul 25 15:22:20 CEST 2018


Hi Konstantin,

On Wed, Jul 25, 2018 at 09:11:30AM +0000, Ananyev, Konstantin wrote:
> Hi Cody,
> 
> > -----Original Message-----
> > From: Cody Doucette [mailto:doucette at bu.edu]
> > Sent: Thursday, July 19, 2018 4:58 PM
> > To: Ananyev, Konstantin <konstantin.ananyev at intel.com>; Olivier Matz <olivier.matz at 6wind.com>; Dumitrescu, Cristian
> > <cristian.dumitrescu at intel.com>
> > Cc: dev at dpdk.org; michel at digirati.com.br; Cody Doucette <doucette at bu.edu>; Qiaobin Fu <qiaobinf at bu.edu>
> > Subject: [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()
> > 
> > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any
> > other IPv6 extension headers when finding the fragment header.
> > 
> > According to RFC 8200, there is no guarantee that the IPv6
> > Fragment extension header will come before any other extension
> > header, even though it is recommended.
> > 
> > Signed-off-by: Cody Doucette <doucette at bu.edu>
> > Signed-off-by: Qiaobin Fu <qiaobinf at bu.edu>
> > Reviewed-by: Michel Machado <michel at digirati.com.br>
> > ---
> > v2:
> > * Moved IPv6 extension header definitions to lib_net.
> > 
> 
> Looks ok to me, though now drivers/net/failsafe fails to build on freebsd:
> http://mails.dpdk.org/archives/test-report/2018-July/060532.html
> 
> I fixed that locally by commenting out:
> CFLAGS += -D_XOPEN_SOURCE=700
> at drivers/net/failsafe/Makefile
> 
> Not sure what is the root cause here.
> Gaetan, do you remember why we need it for failsafe driver?
> Konstantin
> 

IIRC, I was using it during the parameters parsing.
I don't see this reason anymore.

Removing it I don't see any issue so if you need to, have at it!

-- 
Gaëtan Rivet
6WIND


More information about the dev mailing list