[dpdk-dev] [PATCH v3] net/ixgbe: fix ixgbevf link status

Zhang, Qi Z qi.z.zhang at intel.com
Thu Jul 26 07:17:38 CEST 2018



> -----Original Message-----
> From: Wu, Yanglong
> Sent: Thursday, July 26, 2018 10:25 AM
> To: dev at dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang at intel.com>; Wang, Dong1
> <dong1.wang at intel.com>; Wu, Yanglong <yanglong.wu at intel.com>
> Subject: [PATCH v3] net/ixgbe: fix ixgbevf link status
> 
> ixgbevf can't get right link status unless it check PF link status in wait mode.
> 
> Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu at intel.com>
> ---
> v3:
> change to wait mode in ixgbevf
> ---
> v2:
> no need to set link status again
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 26b192737..b90b352e3 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4006,7 +4006,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev
> *dev,
>  		wait = 0;
> 
>  	if (vf)
> -		diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
> +		/* ixgbevf need to wait to get link status */
> +		diag = ixgbevf_check_link(hw, &link_speed, &link_up, 1);

Sorry, I mislead you in our offline talk.
I think to implement a no_wait ops with a wait method may confuse the user, because an application may call rte_eth_link_get_nowait in the data path, we should not do any time consume tasks.
So maybe the reasonable way is return -ENOTSUP for a nowait request since ixgbevf can't support this due to hardware limitation.
And also the parameter " wait_to_complete" can be omitted in ixgbevf_check_link, since the nowait implementation is not correct and should be removed.


>  	else
>  		diag = ixgbe_check_link(hw, &link_speed, &link_up, wait);
> 
> --
> 2.11.0



More information about the dev mailing list