[dpdk-dev] [PATCH] devtools: check_symbol_change requires bash

[Stephen Hemminger]

On Tue, 31 Jul 2018 16:01:19 +0000
"Mcnamara, John" <john.mcnamara at intel.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, July 31, 2018 4:14 PM
> > To: nhorman at tuxdriver.com
> > Cc: dev at dpdk.org; Stephen Hemminger <stephen at networkplumber.org>
> > Subject: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash
> > 
> > The syntax of check_symbol_change uses some bash syntax.
> > It does not run correctly on Debian where /bin/sh is not the same as
> > /bin/bash.  
> 
> I think this fix may be required for devtools/checkpatches.sh as well
> since it seems to use bash specific call to trap().
> 
> I saw this in an internal bug report but didn't have a system to check
> the fix on. Could you do a quick check.

Yes, checkpatches also needs to be bashifyed.