[dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create()
Dariusz Stojaczyk
dariuszx.stojaczyk at intel.com
Fri Jun 8 14:37:07 CEST 2018
This function returned positive error numbers instead
of negative ones as desbribed in the doc. What's worse,
multiple of its callers only check for (rc < 0) to detect
failure.
It was incorrectly assumed that pthread_create
and pthread_setaffinity_np return negative errnos. They
always returns positive ones, so this patch negates their
return values before returning.
Fixes: 9e5afc72c909 ("eal: add function to create control threads")
Cc: olivier.matz at 6wind.com
Cc: stable at dpdk.org
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk at intel.com>
---
lib/librte_eal/common/eal_common_thread.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 8110ac2..48ef4d6 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -175,7 +175,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
params = malloc(sizeof(*params));
if (!params)
- return -1;
+ return -ENOMEM;
params->start_routine = start_routine;
params->arg = arg;
@@ -185,7 +185,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
if (ret != 0) {
free(params);
- return ret;
+ return -ret;
}
if (name != NULL) {
@@ -228,5 +228,5 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
}
pthread_cancel(*thread);
pthread_join(*thread, NULL);
- return ret;
+ return -ret;
}
--
2.7.4
More information about the dev
mailing list