[dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

Nélio Laranjeiro nelio.laranjeiro at 6wind.com
Tue Jun 19 11:44:18 CEST 2018


On Mon, Jun 18, 2018 at 02:02:10PM -0700, Stephen Hemminger wrote:
> On Mon, 18 Jun 2018 10:52:54 +0200
> Nelio Laranjeiro <nelio.laranjeiro at 6wind.com> wrote:
> 
> >  
> > +struct vxlan_encap_conf vxlan_encap_conf = {
> > +	.select_ipv4 = 1,
> > +	.vni = "\x00\x00\x00",
> > +	.udp_src = RTE_BE16(1),
> 
> Overall looks good. One enhancement I would suggest is to implement generating
> the UDP source port based on a hash of fields from inner packet (as suggested
> in RFC 7348).  This would be enabled by default (use udp source port of 0
> as a flag to enable it).

I'll make the modification for the v4,

Thanks,

-- 
Nélio Laranjeiro
6WIND


More information about the dev mailing list