[dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create()

Olivier Matz olivier.matz at 6wind.com
Mon Jun 25 16:40:47 CEST 2018


On Mon, Jun 18, 2018 at 11:01:40AM +0100, Burakov, Anatoly wrote:
> On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote:
> > This function returned positive error numbers instead
> > of negative ones as desbribed in the doc. What's worse,
> > multiple of its callers only check for (rc < 0) to detect
> > failure.
> > 
> > It was incorrectly assumed that pthread_create
> > and pthread_setaffinity_np return negative errnos. They
> > always returns positive ones, so this patch negates their
> > return values before returning.
> > 
> > Fixes: 9e5afc72c909 ("eal: add function to create control threads")
> > Cc: olivier.matz at 6wind.com
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk at intel.com>
> > ---
> 
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>

Reviewed-by: Olivier Matz <olivier.matz at 6wind.com>

Thanks for the fix.


More information about the dev mailing list