[dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size functions

Verma, Shally Shally.Verma at cavium.com
Tue Jun 26 07:28:19 CEST 2018



>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
>Sent: 25 June 2018 22:10
>To: Verma, Shally <Shally.Verma at cavium.com>; Akhil Goyal <akhil.goyal at nxp.com>; Doherty, Declan <declan.doherty at intel.com>;
>ravi1.kumar at amd.com; Jacob, Jerin <Jerin.JacobKollanukkaran at cavium.com>; Zhang, Roy Fan <roy.fan.zhang at intel.com>; Trahe,
>Fiona <fiona.trahe at intel.com>; tdu at semihalf.com; jianjay.zhou at huawei.com
>Cc: dev at dpdk.org
>Subject: RE: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size functions
>
>External Email
>
>> -----Original Message-----
>> From: Verma, Shally [mailto:Shally.Verma at cavium.com]
>> Sent: Friday, June 22, 2018 6:02 PM
>> To: Akhil Goyal <akhil.goyal at nxp.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch at intel.com>; Doherty, Declan
>> <declan.doherty at intel.com>; ravi1.kumar at amd.com; Jacob, Jerin
>> <Jerin.JacobKollanukkaran at cavium.com>; Zhang, Roy Fan
>> <roy.fan.zhang at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>;
>> tdu at semihalf.com; jianjay.zhou at huawei.com
>> Cc: dev at dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size
>> functions
>>
>> Hi Pablo
>>
>> >-----Original Message-----
>> >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Akhil Goyal
>> >Sent: 21 June 2018 18:29
>> >To: Pablo de Lara <pablo.de.lara.guarch at intel.com>;
>> >declan.doherty at intel.com; ravi1.kumar at amd.com; Jacob, Jerin
>> ><Jerin.JacobKollanukkaran at cavium.com>; roy.fan.zhang at intel.com;
>> >fiona.trahe at intel.com; tdu at semihalf.com; jianjay.zhou at huawei.com
>> >Cc: dev at dpdk.org
>> >Subject: Re: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session
>> >size functions
>> >
>> >External Email
>> >
>> >Hi Pablo,
>> >
>> >
>> >On 6/9/2018 3:32 AM, Pablo de Lara wrote:
>> >> Removed rte_cryptodev_get_header_session_size
>> >> and rte_cryptodev_get_private_session_size functions, as they have
>> >> been substituted with functions specific for symmetric operations,
>> >> with _sym_ word after "rte_cryptodev_".
>> >>
>> >> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
>> >> ---
>
>...
>
>> >> +
>> >> +  - ``rte_cryptodev_get_header_session_size`` is replaced with
>> >> +    ``rte_cryptodev_sym_get_header_session_size``
>> >> +  - ``rte_cryptodev_get_private_session_size`` is replaced with
>> >> +    ``rte_cryptodev_sym_get_private_session_size``
>> >> +
>> >rte_cryptodev_get_private_session_size is not removed in this patch. I
>> >think you missed it in your patch.
>
>Right Akhil, thanks for spotting this. Will fix in next version.
>
>> >
>> >-Akhil
>> >>
>> >>   ABI Changes
>> >>   -----------
>> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.c
>> >> b/lib/librte_cryptodev/rte_cryptodev.c
>> >> index a07904fb9..40e249e79 100644
>> >> --- a/lib/librte_cryptodev/rte_cryptodev.c
>> >> +++ b/lib/librte_cryptodev/rte_cryptodev.c
>> >> @@ -1181,12 +1181,6 @@ rte_cryptodev_sym_session_free(struct
>> rte_cryptodev_sym_session *sess)
>> >>       return 0;
>> >>   }
>> >>
>> >> -unsigned int
>> >> -rte_cryptodev_get_header_session_size(void)
>> >> -{
>> >> -     return rte_cryptodev_sym_get_header_session_size();
>> >> -}
>> >> -
>> >>   unsigned int
>> >>   rte_cryptodev_sym_get_header_session_size(void)
>> >>   {
>>
>> [Shally] I missed this before. I think this implementation either should change to
>> use nb_drivers which support symmetric or else I am not seeing a need for
>> separate sym specific API for header_size since it will always be same for both
>> sym and asym.
>
>The implementation is already using nb_drivers to calculate the size, right?
[Shally] I meant change it to nb_sym_drivers, where nb_sym_drivers = number of drivers that have symmetric capability

>Anyway, I understand that the way asymmetric sessions are done, the API
>will be the same, but this could change in the future and since we have already deprecated the
>generic function (get_header_session_size), I think we should continue and have both _sym and _asym_ functions.
>
[Shally] Ok.
>Thanks,
>Pablo



More information about the dev mailing list