[dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

Verma, Shally Shally.Verma at cavium.com
Tue Jun 26 13:22:17 CEST 2018



>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
>Sent: 26 June 2018 14:53
>To: Verma, Shally <Shally.Verma at cavium.com>
>Cc: Trahe, Fiona <fiona.trahe at intel.com>; akhil.goyal at nxp.com; dev at dpdk.org; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya at cavium.com>; Sahu, Sunila <Sunila.Sahu at cavium.com>; Gupta, Ashish <Ashish.Gupta at cavium.com>
>Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support

//snip

>> -             retval = process_op(qp, ops[i], sess);
>> +             if (ops[i]->type == RTE_CRYPTO_OP_TYPE_SYMMETRIC)
>> +                     retval = process_op(qp, ops[i],
>> +                                     (struct openssl_session *) sess);
>
>Could you rename process_op to process_sym_op?
>
[Shally] Will do.

>Also, I think we need this check for the other PMDs.
>I will send a patch to check if op type is equal to symmetric.
>
>Pablo



More information about the dev mailing list