[dpdk-dev] [PATCH v2] crypto/scheduler: add dynamic logging to scheduler

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Wed Jun 27 16:44:46 CEST 2018


Hi Hari,

> -----Original Message-----
> From: Vemula, Hari KumarX
> Sent: Tuesday, June 12, 2018 6:35 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Pattan, Reshma
> <reshma.pattan at intel.com>; Vemula, Hari KumarX
> <hari.kumarx.vemula at intel.com>
> Subject: [PATCH v2] crypto/scheduler: add dynamic logging to scheduler
> 
> From: hvemulax <hari.kumarx.vemula at intel.com>
> 
> 1.added new logtype for driver.
> 2.registered the new logtype.
> 3.CS_LOG_ERR and RTE_LOG logtypes are replaced with new logtype name.
> 
> Signed-off-by: Hari Kumar <hari.kumarx.vemula at intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan at intel.com>

Some lines are too long now, due to the new macro.
Could you change it to a shorter name? Maybe "CR_SCHED_LOG".

Also, make the following changes:

- Change title to: "crypto/scheduler: add dynamic logging", to avoid duplications
- Modify author to "Hari Kumar"
- Remove unused " CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG"
from config file.
- Remove extra blank line at the end of rte_cryptodev_scheduler.c

Thanks,
Pablo




More information about the dev mailing list