[dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support
Kumar, Ravi1
Ravi1.Kumar at amd.com
Mon Mar 12 12:25:27 CET 2018
>
>
>-----Original Message-----
>From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
>Sent: Friday, March 09, 2018 10:09 PM
>To: Kumar, Ravi1 <Ravi1.Kumar at amd.com>; dev at dpdk.org
>Cc: Hemant Agrawal <hemant.agrawal at nxp.com>; Thomas Monjalon <thomas at monjalon.net>
>Subject: Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support
>
>On 3/9/2018 4:13 PM, Ferruh Yigit wrote:
>> On 3/9/2018 8:42 AM, Ravi Kumar wrote:
>>> Signed-off-by: Ravi Kumar <Ravi1.kumar at amd.com>
>>
>> <...>
>>
>>> diff --git a/drivers/net/axgbe/Makefile b/drivers/net/axgbe/Makefile
>>> new file mode 100644 index 0000000..c8a1e87
>>> --- /dev/null
>>> +++ b/drivers/net/axgbe/Makefile
>>> @@ -0,0 +1,146 @@
>>> +#
>>> +# Copyright (c) 2017 Advanced Micro Devices, Inc.
>>> +# All rights reserved.
>>> +#
>>> +# AMD 10Gb Ethernet driver
>>> +#
>>> +# This file is available to you under your choice of the following two
>>> +# licenses:
>>> +#
>>> +# License 1: GPLv2
>>> +#
>>> +# Copyright (c) 2017 Advanced Micro Devices, Inc.
>>> +#
>>> +# This file is free software; you may copy, redistribute and/or modify
>>> +# it under the terms of the GNU General Public License as published by
>>> +# the Free Software Foundation, either version 2 of the License, or (at
>>> +# your option) any later version.
>>> +#
>>> +# This file is distributed in the hope that it will be useful, but
>>> +# WITHOUT ANY WARRANTY; without even the implied warranty of
>>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>> +# General Public License for more details.
>>> +#
>>> +# You should have received a copy of the GNU General Public License
>>> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
>>> +#
>>> +# This file incorporates work covered by the following copyright and
>>> +# permission notice:
>>> +#
>>> +# Copyright (c) 2013 Synopsys, Inc.
>>> +#
>>> +# The Synopsys DWC ETHER XGMAC Software Driver and documentation
>>> +# (hereinafter "Software") is an unsupported proprietary work of Synopsys,
>>> +# Inc. unless otherwise expressly agreed to in writing between Synopsys
>>> +# and you.
>>> +#
>>> +# The Software IS NOT an item of Licensed Software or Licensed Product
>>> +# under any End User Software License Agreement or Agreement for Licensed
>>> +# Product with Synopsys or any supplement thereto. Permission is hereby
>>> +# granted, free of charge, to any person obtaining a copy of this software
>>> +# annotated with this license and the Software, to deal in the Software
>>> +# without restriction, including without limitation the rights to use,
>>> +# copy, modify, merge, publish, distribute, sublicense, and/or sell copies
>>> +# of the Software, and to permit persons to whom the Software is furnished
>>> +# to do so, subject to the following conditions:
>>> +#
>>> +# The above copyright notice and this permission notice shall be included
>>> +# in all copies or substantial portions of the Software.
>>> +#
>>> +# THIS SOFTWARE IS BEING DISTRIBUTED BY SYNOPSYS SOLELY ON AN "AS IS"
>>> +# BASIS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>>> +# TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
>>> +# PARTICULAR PURPOSE ARE HEREBY DISCLAIMED. IN NO EVENT SHALL SYNOPSYS
>>> +# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>>> +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>>> +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>>> +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>>> +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>> +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>>> +# THE POSSIBILITY OF SUCH DAMAGE.
>>> +#
>>> +# License 2: Modified BSD
>>> +#
>>> +# Copyright (c) 2017 Advanced Micro Devices, Inc.
>>> +# All rights reserved.
>>> +#
>>> +# Redistribution and use in source and binary forms, with or without
>>> +# modification, are permitted provided that the following conditions
>>> +# are met:
>>> +#
>>> +# * Redistributions of source code must retain the above copyright
>>> +# notice, this list of conditions and the following disclaimer.
>>> +# * Redistributions in binary form must reproduce the above copyright
>>> +# notice, this list of conditions and the following disclaimer in
>>> +# the documentation and/or other materials provided with the
>>> +# distribution.
>>> +# * Neither the name of Advanced Micro Devices, Inc. nor the
>>> +# names of its contributors may be used to endorse or promote products
>>> +# derived from this software without specific prior written permission.
>>> +#
>>> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
>>> +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>>> +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
>>> +# ARE DISCLAIMED. IN NO EVENT SHALL <COPYRIGHT HOLDER> BE LIABLE FOR ANY
>>> +# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>>> +# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
>>> +# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>>> +#
>>> +# This file incorporates work covered by the following copyright and
>>> +# permission notice:
>>> +#
>>> +# Copyright (c) 2013 Synopsys, Inc.
>>> +#
>>> +# The Synopsys DWC ETHER XGMAC Software Driver and documentation
>>> +# (hereinafter "Software") is an unsupported proprietary work of Synopsys,
>>> +# Inc. unless otherwise expressly agreed to in writing between Synopsys
>>> +# and you.
>>> +#
>>> +# The Software IS NOT an item of Licensed Software or Licensed Product
>>> +# under any End User Software License Agreement or Agreement for Licensed
>>> +# Product with Synopsys or any supplement thereto. Permission is hereby
>>> +# granted, free of charge, to any person obtaining a copy of this software
>>> +# annotated with this license and the Software, to deal in the Software
>>> +# without restriction, including without limitation the rights to use,
>>> +# copy, modify, merge, publish, distribute, sublicense, and/or sell copies
>>> +# of the Software, and to permit persons to whom the Software is furnished
>>> +# to do so, subject to the following conditions:
>>> +#
>>> +# The above copyright notice and this permission notice shall be included
>>> +# in all copies or substantial portions of the Software.
>>> +#
>>> +# THIS SOFTWARE IS BEING DISTRIBUTED BY SYNOPSYS SOLELY ON AN "AS IS"
>>> +# BASIS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>>> +# TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
>>> +# PARTICULAR PURPOSE ARE HEREBY DISCLAIMED. IN NO EVENT SHALL SYNOPSYS
>>> +# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>>> +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>>> +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>>> +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>>> +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>> +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>>> +# THE POSSIBILITY OF SUCH DAMAGE.
>>
>> Hi Ravi,
>>
>> What has been modified in this release?
>>
>> As far as I remember axgbe skipped previous release because driver was
>> working on switching to the SPDX tags? And this version of the patch
>> is again without SPDX tags.
>>
>> This driver is out for a while now and not able to merged yet. If SPDX
>> work is blocking you, I would suggest taking this issue to the
>> tech-board and ask for exception for it.
>
>I just recognized that (Thanks to Pablo) patch 18/18 coverts licensing to SPDX.
>Great to see that issue has been solved.
>
>Only can you please distribute the patch 18/18 to the actual patches and add licensing correct at first time?
>
>Thanks,
>ferruh
Hi Ferruh,
Thanks for reviewing. We will fix this in the next version of the patches.
Regards,
Ravi
More information about the dev
mailing list