[dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

Thomas Monjalon thomas at monjalon.net
Wed Mar 28 09:29:35 CEST 2018


28/03/2018 04:08, Tan, Jianfeng:
> Hi Thomas ,
> 
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > 27/03/2018 15:59, Anatoly Burakov:
> > > Under the hood, we create a separate thread to deal with replies to
> > > asynchronous requests, that will just wait to be notified by the
> > > main thread, or woken up on a timer.
> > 
> > I really don't like that a library is creating a thread.
> > We don't even know where the thread is created (which core).
> > Can it be a rte_service? or in the interrupt thread?
> 
> Agree that we'd better not adding so many threads in a library.
> 
> I was considering to merge all the threads into the interrupt thread, however, we don't have an interrupt thread in freebsd. Further, we don't implement alarm API in freebsd. That's why I tend to current implementation, and optimize it later.

I would prefer we improve the current code now instead of polluting more
with more uncontrolled threads.

> For rte_service, it may be not a good idea to reply on it as it needs explicit API calls to setup.

I don't see the issue of the explicit API.
The IPC is a new service.




More information about the dev mailing list