[dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

Radu Nicolau radu.nicolau at intel.com
Thu Mar 29 12:06:10 CEST 2018


On 3/28/2018 3:28 PM, Anoob Joseph wrote:
> Hi Akhil, Radu,
>
> Did you get time to review the patch?
>
> Thanks,
> Anoob
>
> On 23/03/18 11:20, Anoob Joseph wrote:
>> Removing redundant strncmp in parsing long arguments. The getopt library
>> provides means to identify long options using the "val" field of
>> structure option. The existing code gets 0 as "val" for all long
>> arguments and then uses strncmp to figure out which long option was
>> being referred to. Fixing this.
>>
>> In addition, the macros and enums used for long arguments have been
>> renamed and repositioned adhering to the general convention followed in
>> various other apps, like l3fwd.
>>
>> Signed-off-by: Anoob Joseph <anoob.joseph at caviumnetworks.com>
>> ---
Acked-by: Radu Nicolau <radu.nicolau at intel.com> 
<mailto:radu.nicolau at intel.com>


More information about the dev mailing list