[dpdk-dev] [PATCH 02/18] drivers: bus: pci: fix strncpy dangerous code
Andy Green
andy at warmcat.com
Tue May 8 06:29:38 CEST 2018
In function ‘pci_get_kernel_driver_by_path’,
inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:317:8:
/home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
strncpy(dri_name, name + 1, strlen(name + 1) + 1);
---
drivers/bus/pci/linux/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 4630a8057..b5bdfd33e 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -54,7 +54,8 @@ pci_get_kernel_driver_by_path(const char *filename, char *dri_name)
name = strrchr(path, '/');
if (name) {
- strncpy(dri_name, name + 1, strlen(name + 1) + 1);
+ strncpy(dri_name, name + 1, sizeof(dri_name) - 1);
+ dri_name[sizeof(dri_name) - 1] = '\0';
return 0;
}
More information about the dev
mailing list