[dpdk-dev] [v3, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter

[Gujjar, Abhinandan S]

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Monday, May 7, 2018 3:23 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar at intel.com>
> Cc: hemant.agrawal at nxp.com; akhil.goyal at nxp.com; dev at dpdk.org; Vangati,
> Narender <narender.vangati at intel.com>; Rao, Nikhil <nikhil.rao at intel.com>;
> Eads, Gage <gage.eads at intel.com>
> Subject: Re: [v3,2/5] eventdev: add APIs and PMD callbacks for crypto adapter
> 
> -----Original Message-----
> > Date: Sun, 6 May 2018 00:17:07 +0530
> > From: Abhinandan Gujjar <abhinandan.gujjar at intel.com>
> > To: jerin.jacob at caviumnetworks.com, hemant.agrawal at nxp.com,
> > akhil.goyal at nxp.com, dev at dpdk.org
> > CC: narender.vangati at intel.com, abhinandan.gujjar at intel.com,
> > nikhil.rao at intel.com, gage.eads at intel.com
> > Subject: [v3,2/5] eventdev: add APIs and PMD callbacks for crypto
> > adapter
> > X-Mailer: git-send-email 1.9.1
> >
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar at intel.com>
> > ---
> >  drivers/event/sw/sw_evdev.c            |  13 +++
> >  lib/librte_eventdev/rte_eventdev.c     |  25 +++++
> >  lib/librte_eventdev/rte_eventdev.h     |  54 ++++++++++
> >  lib/librte_eventdev/rte_eventdev_pmd.h | 187
> > +++++++++++++++++++++++++++++++++
> >  4 files changed, 279 insertions(+)
> >
> > --- a/lib/librte_eventdev/rte_eventdev.h
> > +++ b/lib/librte_eventdev/rte_eventdev.h
> > @@ -8,6 +8,8 @@
> >  #ifndef _RTE_EVENTDEV_H_
> >  #define _RTE_EVENTDEV_H_
> >
> > +#include <rte_compat.h>
> 
> Why rte_compat.h ? Is it by mistake? I could compile without this change.
Just notice that, I too got a successful compilation without this file.
Initially, I got an error when APIs were marked as rte_experimental. Then, I had to include this file!
May be this file is included somewhere else. Anyway, I will remove it.
> 
> > +
> >  /**
> >   * @file
> >   *
> > @@ -1135,6 +1137,58 @@ struct rte_event {  int __rte_experimental
> > rte_event_timer_adapter_caps_get(uint8_t dev_id, uint32_t *caps);
> >
> > @@ -70,6 +70,9 @@
> >  		((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \
> >
> 	(RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ))
> >
> > +#define RTE_EVENT_CRYPTO_ADAPTER_SW_CAP \
> > +		RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA
> 
> I thought, SW driver has support for
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND.
> If not, please ignore this comment.
> 
> 
> With above changes:
> Acked-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>