[dpdk-dev] [PATCH] test: fix wrong function type casing
Jerin Jacob
jerin.jacob at caviumnetworks.com
Thu May 10 10:29:20 CEST 2018
make flip_bit() as lcore_function_t.
Found this issue with gcc 8.1
test/test/test_distributor_perf.c: In function ‘time_cache_line_switch’:
test/test/test_distributor_perf.c:59:24: warning: cast between
incompatible function types from ‘void (*)(volatile uint64_t *)’ {aka
‘void (*) (volatile long unsigned int *)’} to ‘int (*)(void *)’
[-Wcast-function-type] rte_eal_remote_launch((lcore_function_t *)flip_bit,
&data[0], slaveid);
Cc: bruce.richardson at intel.com
Cc: stable at dpdk.org
Fixes: c3eabff124e6 ("distributor: add unit tests")
Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
---
test/test/test_distributor_perf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/test/test_distributor_perf.c b/test/test/test_distributor_perf.c
index 557715e13..edf1998ab 100644
--- a/test/test/test_distributor_perf.c
+++ b/test/test/test_distributor_perf.c
@@ -31,7 +31,7 @@ struct worker_stats worker_stats[RTE_MAX_LCORE];
* worker thread used for testing the time to do a round-trip of a cache
* line between two cores and back again
*/
-static void
+static int
flip_bit(volatile uint64_t *arg)
{
uint64_t old_val = 0;
@@ -41,6 +41,7 @@ flip_bit(volatile uint64_t *arg)
old_val = *arg;
*arg = 0;
}
+ return 0;
}
/*
--
2.17.0
More information about the dev
mailing list