[dpdk-dev] [PATCH v4 2/2] net/mlx4: advertise supported RSS hash functions

[Ophir Munk]

Shahaf asked for it in his review

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Sunday, May 13, 2018 7:13 PM
> To: Ophir Munk <ophirmu at mellanox.com>
> Cc: dev at dpdk.org; Adrien Mazarguil <adrien.mazarguil at 6wind.com>; Olga
> Shern <olgas at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>
> Subject: Re: [PATCH v4 2/2] net/mlx4: advertise supported RSS hash
> functions
> 
> 13/05/2018 17:39, Ophir Munk:
> >  	info->speed_capa =
> > -			ETH_LINK_SPEED_1G |
> > -			ETH_LINK_SPEED_10G |
> > -			ETH_LINK_SPEED_20G |
> > -			ETH_LINK_SPEED_40G |
> > -			ETH_LINK_SPEED_56G;
> > +		ETH_LINK_SPEED_1G |
> > +		ETH_LINK_SPEED_10G |
> > +		ETH_LINK_SPEED_20G |
> > +		ETH_LINK_SPEED_40G |
> > +		ETH_LINK_SPEED_56G;
> 
> Not sure why you re-indent.
> For info, line continuation in control statements must be done with 2 tabs:
> 	https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F
> %2Fdpdk.org%2Fdoc%2Fguides%2Fcontributing%2Fcoding_style.html%23ge
> neral&data=02%7C01%7Cophirmu%40mellanox.com%7C521136e06b61475a
> 99c308d5b8ec58fa%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7
> C636618247609249241&sdata=GkEBudFg9ukUbGM9Wi%2F84vT%2FQRv3qX
> KuT%2BiFN0ziVjc%3D&reserved=0
> In this case, it is not a control statement, so I guess 1 or 2 tabs can be
> accepted.
>