[dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested offload is not supported

Andrew Rybchenko arybchenko at solarflare.com
Mon May 14 09:36:15 CEST 2018


The series has fixes for problems discussed in [1].

Basically it does not allow unsupported offloads to pass.

If fixes regressions for PMDs which carefully check offloads before,
but these checks are removed now in favor of checks in ethdev.

It may break applications which request some offload which is not
supported by underlying PMD, but does not actually used.

Depending on discussion results it should be either dropped or applied.

[1] http://dpdk.org/ml/archives/dev/2018-May/101261.html

v1 -> v2:
 - use IGNORE flag to separate old and new offload API cases on
   Tx queue setup and avoid expected errors if old API is used
   as suggested by Shahaf
 - remove convertion of rxmode bits on Rx queue setup since exactly
   these bits are removed

Andrew Rybchenko (3):
  ethdev: fail configure if requested offload is not supported
  ethdev: fail if Tx queue offload is not supported
  ethdev: fail if Rx queue offload is not supported

 lib/librte_ethdev/rte_ethdev.c | 62 +++++++++++++++++++---------------
 1 file changed, 35 insertions(+), 27 deletions(-)

-- 
2.17.0



More information about the dev mailing list