[dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

[Ferruh Yigit]

On 5/14/2018 6:04 AM, Andy Green wrote:
> /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:
> In function ‘elink_check_kr2_wa’:
> /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28:
> error: bitwise comparison always evaluates to false
> [-Werror=tautological-compare]
>         ((next_page & 0xe0) == 0x2))));
> 
> This was fixed elsewhere in 2014

To be able to apply this fix in dpdk I think we need maintainers ack on this
change, they are cc'ed.

> 
> Signed-off-by: Andy Green <andy at warmcat.com>
> Fixes: b5bf7719221d ("bnx2x: driver support routines")
> Cc: stable at dpdk.org
> ---
>  drivers/net/bnx2x/elink.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> index cceae6f9b..74e1bead3 100644
> --- a/drivers/net/bnx2x/elink.c
> +++ b/drivers/net/bnx2x/elink.c
> @@ -12921,7 +12921,7 @@ static void elink_check_kr2_wa(struct elink_params *params,
>  	 */
>  	not_kr2_device = (((base_page & 0x8000) == 0) ||
>  			  (((base_page & 0x8000) &&
> -			    ((next_page & 0xe0) == 0x2))));
> +			    ((next_page & 0xe0) == 0x20))));
>  
>  	/* In case KR2 is already disabled, check if we need to re-enable it */
>  	if (!(vars->link_attr_sync & LINK_ATTR_SYNC_KR2_ENABLE)) {
>