[dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

Ferruh Yigit ferruh.yigit at intel.com
Mon May 14 14:41:30 CEST 2018


On 5/14/2018 12:45 PM, Doherty, Declan wrote:
> On 24/04/2018 12:29 PM, Matan Azrad wrote:
>> The bonding PMD decides to activate\deactivate its slaves according to
>> the slaves link statuses.
>> Thus, it registers to the LSC events of the slaves ports and
>> activates\deactivates them from its LSC callbacks called asynchronously
>> by the host thread when the slave link status is changed.
>>
>> In addition, the bonding PMD uses the callback for slave activation
>> when it tries to start it, this operation is probably called by the
>> master thread.
>>
>> Consequently, a slave may be activated in the same time by two
>> different threads and may cause a lot of optional errors, for example,
>> slave mempool recreation with the same name causes an error.
>>
>> Synchronize the critical section in the LSC callback using a special
>> new spinlock.
>>
>> Fixes: 414b202343ce ("bonding: fix initial link status of slave")
>> Fixes: a45b288ef21a ("bond: support link status polling")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Matan Azrad <matan at mellanox.com>
>> ---
> ...
>>
> 
> Acked-by: Declan Doherty <declan.doherty at intel.com>
> 

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list