[dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int

Andy Green andy at warmcat.com
Thu May 17 15:59:41 CEST 2018



On 05/17/2018 09:55 PM, Bruce Richardson wrote:
> On Thu, May 17, 2018 at 09:48:57PM +0800, Andy Green wrote:
>> Signed-off-by: Andy Green <andy at warmcat.com>
>> ---
> 
> What's the reason for this change of type?

I was asked to do it on the list... the original patch I sent was 
triggered by gcc8 warnings and just casted it away.  But the comment was 
that as an int, it could return negative error codes, so better to 
change them all.

It thereby became something in the way of a refactor rather than a gcc 8 
fix any more.

-Andy



More information about the dev mailing list