[dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

Ferruh Yigit ferruh.yigit at intel.com
Tue May 22 11:50:46 CEST 2018


On 5/15/2018 1:56 PM, Varghese, Vipin wrote:
> HI Keith,
> 
> Thanks for the input, please find my answer inline to email therad
> 
> <Snipped>
> 
>>> +		/* TODO: request info from primary to set up Rx and Tx */
>>
>> What is the rule (if we have one) about having TODO, FIXME, … like comments in
>> the code? Maybe remove the todo and create a enhancement request for later.
>>
> 
> I am not aware of the 'To Do' planned. This came in as part of logic block from previous commit for all PMD to support Secondary

Specially when there is a work not planned for this, agreed to drop todo, can
you please send a new version without that note please?

> 
> <Snipped> 
> 
>>
>> Regards,
>> Keith
> 



More information about the dev mailing list