[dpdk-dev] [PATCH v10] devtools: alert on new instances of rte_panic and rte_exit

[Thomas Monjalon]

Hi,

30/04/2018 08:45, Arnon Warshavsky:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> +		check_forbidden_additions -

This is consuming stdin.
I guess the checkpatch.pl will have nothing to check in the next step.
We should merge Neil's patch first, because he is adding a tmpfile
to solve the issue of stdin read only once.

> +		[ $? -eq 0 ] || return 0

This test looks reversed: if the result is not 0, we should not return 0.
And by the way, I think it is better to continue with other checks.
Neil's patch is setting ret=1, continue and return at the end.

>  		report=$($DPDK_CHECKPATCH_PATH $options - 2>/dev/null)