[dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log

Mody, Rasesh Rasesh.Mody at cavium.com
Thu Nov 8 23:57:37 CET 2018


>From: Stephen Hemminger <stephen at networkplumber.org>
>Sent: Thursday, November 08, 2018 1:39 PM
>
>On Thu, 8 Nov 2018 21:19:26 +0000
>"Mody, Rasesh" <Rasesh.Mody at cavium.com> wrote:
>
>> Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange
>> dynamic log types to the top and configurable log types to bottom.
>> Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE
>>
>> Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name")
>>
>> Signed-off-by: Rasesh Mody <rasesh.mody at cavium.com>
>
>
>Looks good to me.
>
>You might also want to address the excessive number of INFO messages in
>bnx2x.c. There are things like debug messages at INFO level, extra new lines
>and banner bars.

I'll send follow up patch addressing above.

Thanks!
-Rasesh
>
>Acked-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the dev mailing list