[dpdk-dev] [PATCH] devtools: disable coloring of git-log output

Thomas Monjalon thomas at monjalon.net
Mon Nov 19 00:01:44 CET 2018


23/10/2018 10:52, Ali Alnubani:
> Colored git-log outputs will have escape characters
> appended to hashes, causing check-git-log.sh to fail
> with `error: malformed object name ?[33m<hash>?[m` when doing
> `git tag -l --contains <colored_hash>`.

I guess it is due to a config specifying to color "always".

> Signed-off-by: Ali Alnubani <alialnu at mellanox.com>
> ---
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> -git log --oneline --reverse $range |
> +git log --no-color --oneline --reverse $range |

There are a lot more "git log" calls in this script.
I wonder whether we should add this option everywhere.




More information about the dev mailing list