[dpdk-dev] [dpdk-stable] [PATCH v3] net/ena: fix out of order completion

Ferruh Yigit ferruh.yigit at intel.com
Thu Nov 22 09:48:40 CET 2018


On 11/21/2018 4:14 PM, Rafał Kozik wrote:
> Hello Ferruh,
> 
> this patch fix issue in Rx path which could have caused receive of
> wrong packets.
> If it is possible, I would be very grateful if this patch could be
> applied to v18.11.

Sure, this is a driver only patch so risk is all on you and if you prefer to get
it we can get it as long it doesn't break anything on rest of the DPDK.

Only it would be better to address these kind of issues in early rc1 stages,
instead of a few days before release. Prioritizing testing on rc1, and even
sharing a brief test status result on release status meeting, as done by some
other companies, would be great.

Thanks,
ferruh

> 
> Best regards,
> Rafal
> 
> śr., 21 lis 2018 o 16:16 Ferruh Yigit <ferruh.yigit at intel.com> napisał(a):
>>
>> On 11/21/2018 8:21 AM, Rafal Kozik wrote:
>>> rx_buffer_info should be refill not linearly, but out of order.
>>> IDs should be taken from empty_rx_reqs array.
>>>
>>> rx_refill_buffer is introduced to temporary storage
>>> bulk of mbufs taken from pool.
>>>
>>> In case of error unused mbufs are put back to pool.
>>>
>>> Fixes: c2034976673d ("net/ena: add Rx out of order completion")
>>> Cc: stable at dpdk.org
>>>
>>> Signed-off-by: Rafal Kozik <rk at semihalf.com>
>>> Acked-by: Michal Krawczyk <mk at semihalf.com>
>>
>> Hi Rafal,
>>
>> This patch sent after rc4, I suggest pushing this out to next release, any
>> objection? Is this really a critical patch to get in at this stage?



More information about the dev mailing list