[dpdk-dev] [PATCH v3] doc: add meson build to contributing guide

Thomas Monjalon thomas at monjalon.net
Sat Nov 24 19:57:46 CET 2018


14/11/2018 15:30, Kovacevic, Marko:
> > Patches has to be validated for meson builds. Updating documentation for
> > meson build steps in Checking Compilation category.
> > 
> > Signed-off-by: Vipin Varghese <vipin.varghese at intel.com>
> > --- a/doc/guides/contributing/patches.rst
> > +++ b/doc/guides/contributing/patches.rst
> > @@ -468,6 +468,12 @@ The recommended configurations and options to
> > test compilation prior to submitti
> >     export DPDK_DEP_PCAP=y
> >     export DPDK_DEP_SSL=y
> > 
> > +Compliation of patches has to be tested using meson::
> > +
> > +    ./devtools/test-meson-builds.sh
> > +
> > +This will test for shared and static builds. If gcc arm cross compiler
> > +is installed, cross build is tested too.
> > 
> >  Sending Patches
> >  ---------------
> 
> Ran the script all runs fine 
> 
> Tested-by: Marko Kovacevic <marko.kovacevic at intel.com>
> Acked-by: Marko Kovacevic <marko.kovacevic at intel.com>

Yes we must add such explanation, but it can be improved.

We should make clear that meson must be tested in addition of make.

We could be more explicit about cross-compilation, saying on x86 host,
both x86 and Arm can be compiled thanks to the cross compilers.

More details:
- s/Compliation/Compilation/
- the double blank line is removed before next header





More information about the dev mailing list