[dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

Burakov, Anatoly anatoly.burakov at intel.com
Thu Nov 29 16:36:56 CET 2018


On 29-Nov-18 3:18 PM, Anatoly Burakov wrote:
> We already trigger a mem event notification inside the walk function,
> no need to do it twice.
> 
> Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> ---
>   lib/librte_eal/common/rte_malloc.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c
> index 0da5ad5e8..750a83c2c 100644
> --- a/lib/librte_eal/common/rte_malloc.c
> +++ b/lib/librte_eal/common/rte_malloc.c
> @@ -518,10 +518,6 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach)
>   		rte_errno = -wa.result;
>   		ret = -1;
>   	} else {
> -		/* notify all subscribers that a new memory area was added */
> -		if (attach)
> -			eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC,
> -					va_addr, len);
>   		ret = 0;
>   	}
>   unlock:
> 
Oops, dupe.

-- 
Thanks,
Anatoly


More information about the dev mailing list