[dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

Thomas Monjalon thomas at monjalon.net
Tue Oct 2 11:51:09 CEST 2018


02/10/2018 10:59, Jens Freimann:
> On Tue, Oct 02, 2018 at 09:57:52AM +0200, Thomas Monjalon wrote:
> >02/10/2018 09:19, Jens Freimann:
> >> On Mon, Oct 01, 2018 at 01:13:32PM +0000, Iremonger, Bernard wrote:
> >> >./devtools/check-git-log.sh -1
> >> >Headline too long:
> >> >        app/testpmd: add forwarding mode to simulate a noisy neighbour
> >>
> >> I'm sorry, I failed to use checkpatches.sh correctly :) I did:
> >>
> >> #> git show | DPDK_CHECKPATCH_PATH="/home/jfreiman/code/linux/scripts/checkpatch.pl" devtools/checkpatches.sh --
> >>
> >> 1/1 valid patch
> >
> >Why this command is not correct?
> 
> checkpatches.sh looks for the string "Subject:" which is not included
> in git show output. Using cat on the patch file instead will work. 

Yes indeed.

As an improvement, we could check for "git show" output, starting with "commit" word.






More information about the dev mailing list