[dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

Ananyev, Konstantin konstantin.ananyev at intel.com
Wed Oct 3 11:17:18 CEST 2018



> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Wednesday, October 3, 2018 9:59 AM
> To: Ananyev, Konstantin <konstantin.ananyev at intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Iremonger, Bernard <bernard.iremonger at intel.com>;
> Mcnamara, John <john.mcnamara at intel.com>; Kovacevic, Marko <marko.kovacevic at intel.com>; Thomas Monjalon
> <thomas at monjalon.net>; Yigit, Ferruh <ferruh.yigit at intel.com>; Andrew Rybchenko <arybchenko at solarflare.com>; Olivier Matz
> <olivier.matz at 6wind.com>; dev at dpdk.org; shahafs at mellanox.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition
> 
> -----Original Message-----
> > Date: Wed, 3 Oct 2018 08:53:22 +0000
> > From: "Ananyev, Konstantin" <konstantin.ananyev at intel.com>
> > To: Jerin Jacob <jerin.jacob at caviumnetworks.com>, "Lu, Wenzhuo"
> >  <wenzhuo.lu at intel.com>, "Wu, Jingjing" <jingjing.wu at intel.com>,
> >  "Iremonger, Bernard" <bernard.iremonger at intel.com>, "Mcnamara, John"
> >  <john.mcnamara at intel.com>, "Kovacevic, Marko" <marko.kovacevic at intel.com>,
> >  Thomas Monjalon <thomas at monjalon.net>, "Yigit, Ferruh"
> >  <ferruh.yigit at intel.com>, Andrew Rybchenko <arybchenko at solarflare.com>,
> >  Olivier Matz <olivier.matz at 6wind.com>
> > CC: "dev at dpdk.org" <dev at dpdk.org>, "shahafs at mellanox.com"
> >  <shahafs at mellanox.com>
> > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
> >  checksum	definition
> >
> >
> > Hi Jerin,
> 
> Hi Konstantin,
> 
> >
> > >
> > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and
> > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum
> > > failure.
> > >
> > > - To use hardware Rx outer UDP checksum offload, the user needs to
> > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath.
> > >
> > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure
> > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> >
> > Looks ok to me in general.
> > Just wonder is there any PMD that supports all these new features?
> 
> octeontx2 PMD has this feature. I am planning to push the PMD for v19.02.
> Before that I adding all the common code change to avoid the dependency.

Ok, but why then ethdev/mbuf changes has to go into 18.11?
Do you plan your new PMD backward compatible with 18.11 LTS?
Konstantin


More information about the dev mailing list