[dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function

Xiaolong Ye xiaolong.ye at intel.com
Wed Oct 3 21:34:39 CEST 2018


rte_strscpy is safer to use.

Signed-off-by: Xiaolong Ye <xiaolong.ye at intel.com>
---
 examples/vdpa/main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
index f96fa88b7..c5e8f58ec 100644
--- a/examples/vdpa/main.c
+++ b/examples/vdpa/main.c
@@ -13,6 +13,7 @@
 #include <rte_vhost.h>
 #include <rte_vdpa.h>
 #include <rte_pci.h>
+#include <rte_string_fns.h>
 
 #include <cmdline_parse.h>
 #include <cmdline_socket.h>
@@ -73,7 +74,7 @@ parse_args(int argc, char **argv)
 		case 0:
 			if (strncmp(long_option[idx].name, "iface",
 						MAX_PATH_LEN) == 0) {
-				strncpy(iface, optarg, MAX_PATH_LEN);
+				rte_strscpy(iface, optarg, MAX_PATH_LEN);
 				printf("iface %s\n", iface);
 			}
 			if (!strcmp(long_option[idx].name, "interactive")) {
@@ -325,7 +326,7 @@ static void cmd_create_vdpa_port_parsed(void *parsed_result,
 	struct cmd_create_result *res = parsed_result;
 	struct rte_vdpa_dev_addr addr;
 
-	strncpy(vports[devcnt].ifname, res->socket_path, MAX_PATH_LEN);
+	rte_strscpy(vports[devcnt].ifname, res->socket_path, MAX_PATH_LEN);
 	if (rte_pci_addr_parse(res->bdf, &addr.pci_addr) != 0) {
 		cmdline_printf(cl, "Unable to parse the given bdf.\n");
 		return;
-- 
2.17.1



More information about the dev mailing list