[dpdk-dev] [PATCH v3 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

Igor Russkikh Igor.Russkikh at aquantia.com
Thu Oct 4 11:42:16 CEST 2018


Hi Ferruh,

Thanks again for the review, we'll investigate and work on your comments!

> > +CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y
> Just to check, default enable in "common_base" means PMD supports all
> architectures (x86_64, i686, arm, ppc) and both Linux and FreeBSD.
> If this is not the case, please disable in common_base and enable in whatever
> supported.

We actually don't have an ability to test and verify on PPC.
We are pretty confident on x86_64, i686 and arm.

Thus, will it be ok to add `N` into defconfig_ppc_64-power8-linuxapp-gcc only?

> Thanks for the update. But a reminder, each patch should be build and
> functional, there are build errors when first patch applied. I think build is
> broken until 7/22.
> 
> Can you please re-work the patchset to make each patch compiles?

Thats strange because we explicitly tested that.
CI also states its OK:
http://patchwork.dpdk.org/project/dpdk/list/?series=1598&submitter=&state=*&q=&archive=&delegate=

Could it be some custom build environment on your side, or may be you do apply it
on different base, not master?

Regards,
  Igor


More information about the dev mailing list